[kanadgupta]

Summary

• upgrades this repo to vitest 5. as part of this...
  • addresses a few warnings as part of this upgrade
  • adds a tiny top-level config file so we can run tests from the root (this is one of those extremely small DX papercuts that's been bugging me like crazy 😅)
  • tweaks the cwd setup in a few tests so they can be run from the root
  • adds a test:vitest script to the root to run every unit and integration project (e2e and live projects are excluded; pnpm test:e2e still owns the build-then-run path)
  • drops the per-project resolve/plugin duplication in apps/cli/vitest.config.ts, since Vitest 5 inline projects extend the root config

Note: @effect/vitest@4.0.0-rc.112 declares vitest <5, so pnpm warns about the peer range. Every suite passes on Vitest 5, and the bump to an @effect/vitest release that targets Vitest 5 lands separately in #6582.

Checklist

• The PR title follows Conventional Commits (e.g. fix(cli): …).
• Tests added or updated for the change.
• From the repository root, pnpm check:all passes; relevant package tests pass for every touched workspace, and pnpm types:check passes for each touched TypeScript workspace (or workspace declaring it).

[github-actions]

🤖 AI Review

Verified 9 Claude and 3 Codex findings; three overlapping pairs deduplicate to 9 findings, all confirmed. The highest-risk issue is that @effect/vitest explicitly excludes Vitest 5. The PR also introduces broken test/CI wiring, an internally inconsistent Vitest plugin configuration, incidental runtime dependency drift, and several nits.

Findings

Severity	Location	Category	Sources	Claim
🟠 MAJOR	pnpm-lock.yaml:939	dependencies	claude	The Vitest 5 upgrade runs @effect/vitest outside its declared peer range.
🟡 MINOR	commitlint.config.js:16	ci-configuration	claude+codex	The new deps scope passes commitlint but remains rejected by the pull-request title check.
🟡 MINOR	apps/cli/vitest.config.ts:57	test-infrastructure	claude	The per-project Dockerfile loader was removed even though the retained configuration says inline projects do not inherit root Vite configuration.
🟡 MINOR	package.json:16	test-infrastructure	claude+codex	The aggregate test:vitest script includes E2E projects but bypasses their required CLI build.
🟡 MINOR	pnpm-lock.yaml:299	dependencies	claude	The lockfile regeneration includes unrelated upgrades to shipped runtime dependencies.
⚪ NIT	pnpm-workspace.yaml:34	style	claude	The new Vitest catalog value is unquoted, unlike the value it replaces and nearly all sibling catalog values.
⚪ NIT	packages/stack/src/state/ownership.integration.test.ts:271	style	claude	This new call site uses cwd: cwd while the equivalent sibling changes use property shorthand.
⚪ NIT	apps/cli/src/commands/experimental/stack/start/start.e2e.test.ts:52	comments	claude+codex	The newly added cwd comments narrate the following assignments instead of explaining non-obvious rationale.
⚪ NIT	pnpm-workspace.yaml:110	maintenance	claude	The minimumReleaseAgeExclude entries for @types/bun@1.4.0 and bun-types@1.4.0 are stale after the lockfile moved to 1.4.1.

Findings outside the diff

• 🟠 MAJOR pnpm-lock.yaml:939 — The Vitest 5 upgrade runs @effect/vitest outside its declared peer range.
• ⚪ NIT pnpm-workspace.yaml:110 — The minimumReleaseAgeExclude entries for @types/bun@1.4.0 and bun-types@1.4.0 are stale after the lockfile moved to 1.4.1.

Stats

Claude findings: 9 · Codex findings: 3 · Confirmed: 9 · Refuted: 0 · Uncertain: 0

---

Models: claude-opus-5 + gpt-5.6-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

[kanadgupta]

Follow-up on the two AI review findings outside the diff:

• @effect/vitest peer range: confirmed. 4.0.0-rc.112 declares vitest >=4.1.0 <5.0.0, and the first release that accepts Vitest 5 (rc.113) also requires effect ^4.0.0-rc.113, so fixing it here means the full Effect bump. pnpm only warns on this and every suite passes, so this PR leaves it as-is and chore: bump effect and friends to latest rc #6582 carries the bump.
• minimumReleaseAgeExclude entries for @types/bun@1.4.0 / bun-types@1.4.0: no longer stale. 40ace99 pinned the lockfile back to 1.4.0, so those exclusions are still needed and are unchanged from the base branch.