Non thermal models clean up and refactor - #295
Open
samaloney wants to merge 1 commit into
Open
Conversation
samaloney
force-pushed
the
non-thermal-models-refactor
branch
from
August 4, 2026 15:23
570de73 to
80c057e
Compare
samaloney
commented
Aug 5, 2026
Member
Author
There was a problem hiding this comment.
It much easier to see that gauss_legendre and gauss_legendre do almost the same thing the only difference is when the mapping to the real limits is done before gauss_legendre or after in gauss_legendre which mean the numerical error aren't folded in to the integration
samaloney
force-pushed
the
non-thermal-models-refactor
branch
from
August 5, 2026 19:55
2bd53b3 to
fbfc6da
Compare
* Increase edge case test coverage for later refactor * Update some copy / paste errors * Inclue in the dos * Use public scipy API * Modernise some of the iternals and extract constants.
samaloney
force-pushed
the
non-thermal-models-refactor
branch
from
August 5, 2026 21:22
fbfc6da to
af6b2c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Less code, more readable code, and some performance improvements
gauss_legendreport and thefixed_quad_batchare almost identical which should now be clearer the later is numerically better as the scaling operations are not compounded in the integration as they are done at the end - changed default tofixed_quad_batchAI Assistance Disclosure
AI tools were used for: