Repository navigation
build(deps-dev): override markdown-it to 15.0.3 (alerts #9-#11) - #56
Merged
Merged
Conversation
markdown-it is a dev-only transitive dependency: remote-ssh-tunnel -> markdownlint-cli2@0.23.3 -> markdown-it@15.0.1. markdownlint-cli2 0.23.3 pins markdown-it exactly to 15.0.1, so a lockfile-only bump cannot reach 15.0.3; an npm override (patch, same major) does. Also refresh follow-redirects 1.16.0 -> 1.16.1 in the lockfile (within axios's ^1.16.0) so CI's npm audit --omit=dev gate passes.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR for Dependabot alerts #9, #10 and #11 (markdown-it; #9 high fixed in 15.0.2, #11 high and #10 low fixed in 15.0.3). Dependabot has opened no PR for them.
Dependency path
remote-ssh-tunnel(devDependency) ->markdownlint-cli2@0.23.3->markdown-it@15.0.1(dev only, fromnpm ls markdown-it --all).Change
markdown-it15.0.1 -> 15.0.3 through an npmoverridesentry, next to the existinguuid,katexandsmol-tomloverrides.follow-redirects1.16.0 -> 1.16.1, lockfile only, within axios's^1.16.0range (@microsoft/dev-tunnels-management->axios@1.20.0->follow-redirects). This clears a new high advisory (GHSA-q3jh-wrc6-jgq8, GHSA-8r9p-f939-6h3c) that makes CI'snpm audit --omit=dev --audit-level=moderatestep fail on current main.Why a companion PR
markdownlint-cli2@0.23.3pinsmarkdown-itexactly to15.0.1, so Dependabot cannot express the fix as a lockfile update. The release that pins 15.0.3,markdownlint-cli2@0.24.0, is a 0.x minor bump (breaking under semver), so this PR uses a same-major patch override instead. The override can be dropped oncemarkdownlint-cli2is bumped to 0.24.0 or later.Local checks (Node 24)
npm ci --ignore-scripts,npm run check(20/20 pass),npm run lint:markdown(0 issues),npm audit --omit=dev --audit-level=moderate(0 vulnerabilities),npm pack --dry-run: all pass.Not fixed here: the full
npm auditstill reports dev-onlybraces(viamarkdownlint-cli2->globby), which has no non-breaking fix.