fix: reject non-boolean filter/join conditions at build time - #271
Merged
andrew-coleman merged 1 commit intoSep 10, 2026
Merged
Conversation
Substrait requires a FilterRel/JoinRel condition to be a boolean
predicate, but resolve_expression allows to bind any expression,
including a bare column reference. This creates a legit-looking
plan that lloks like the pandas `on="key"` idiom but essentially
generates a Cartesian product which on large tables appears to
hang due to the data it has to process.
Add _require_boolean_condition, which infers the bound condition's
type and raises if it is not boolean, wired into filter, join,
nested_loop_join, and lateral_join. The join builders add a hint
pointing at the equi-join idiom (col('a') == col('b')) and cross_join.
Signed-off-by: Thomas Gschwind <thg@zurich.ibm.com>
andrew-coleman
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Substrait requires a FilterRel/JoinRel condition to be a boolean predicate, but resolve_expression allows to bind any expression, including a bare column reference. This creates a legit-looking plan that lloks like the pandas
on="key"idiom but essentially generates a Cartesian product which on large tables appears to hang due to the data it has to process.Add _require_boolean_condition, which infers the bound condition's type and raises if it is not a boolean, wired into filter, join, nested_loop_join, and lateral_join. The join builders add a hint pointing at the equi-join idiom (col('a') == col('b')) and cross_join.
Fixes #270