fix!: derive mark join output from the selected input - #265
Open
alexandrefimov wants to merge 1 commit into
Open
fix!: derive mark join output from the selected input#265alexandrefimov wants to merge 1 commit into
alexandrefimov wants to merge 1 commit into
Conversation
`LEFT_MARK` and `RIGHT_MARK` currently include both inputs in their inferred schema and output names. Consumers expect only the selected input followed by the marker, so generated plans can fail schema validation. Match [Substrait spec v0.99.0](https://github.com/substrait-io/substrait/blob/v0.99.0/site/docs/relations/logical_relations.md#join-operation): keep the left input for `LEFT_MARK` and the right input for `RIGHT_MARK`, then append a nullable boolean marker. Use that output for names, post-join filters, and emit across logical, lateral, and physical joins. Join conditions and residual expressions still use both inputs. Keep correlations into that combined scope offset-based, since the mark join output cannot represent it. Closes substrait-io#263 BREAKING CHANGE: Mark joins no longer expose columns from the other input. Output field indices change, and post-join filters must use only the selected input and the marker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LEFT_MARKandRIGHT_MARKcurrently include both inputs in their inferred schema and output names. Consumers expect only the selected input followed by the marker, so generated plans can fail schema validation.Match Substrait spec v0.99.0: keep the left input for
LEFT_MARKand the right input forRIGHT_MARK, then append a nullable boolean marker. Use that output for names, post-join filters, and emit across logical, lateral, and physical joins.Join conditions and residual expressions still use both inputs. Keep correlations into that combined scope offset-based, since the mark join output cannot represent it.
Closes #263
BREAKING CHANGE: Mark joins no longer expose columns from the other input. Output field indices change, and post-join filters must use only the selected input and the marker.