build(clang-tidy): improve CMake setup and apply fixes#149
Merged
ingomueller-net merged 2 commits intosubstrait-io:mainfrom Apr 9, 2026
Merged
build(clang-tidy): improve CMake setup and apply fixes#149ingomueller-net merged 2 commits intosubstrait-io:mainfrom
ingomueller-net merged 2 commits intosubstrait-io:mainfrom
Conversation
ingomueller-net
requested review from
EpsilonPrime and
westonpace
as code owners
ingomueller-net
force-pushed
the
fix-clang-tidy-issues
branch
2 times, most recently
from
13e43ee to
9852f38
Compare
ingomueller-net
changed the title
clang-tidy
EpsilonPrime
approved these changes
Apr 9, 2026
ingomueller-net
force-pushed
the
fix-clang-tidy-issues
branch
from
9852f38 to
e10ccaf
Compare
This PR improves the way how CMake sets up `clang-tidy` in two ways: (1) It includes a `--header-filter` in order to make `clang-tidy` also check and fix header files and (2) it deactivates `clang-tidy` checks for generated code, namely by `protoc` and ANTLR. This PR then applies more fixes found by `clang-tidy`. Curiously, some of them only show up with substrait-io#148, which consumes `abseil-cpp` differently. Signed-off-by: Ingo Müller <ingomueller@google.com>
This PR applies more fixes found by `clang-tidy`. Curiously, they only show up with substrait-io#148, which consumes `abseil-cpp` differently. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
force-pushed
the
fix-clang-tidy-issues
branch
from
e10ccaf to
7395209
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the way how CMake sets up
clang-tidyin two ways: (1) It includes a--header-filterin order to makeclang-tidyalso check and fix header files and (2) it deactivatesclang-tidychecks for generated code, namely byprotocand ANTLR.This PR then applies more fixes found by
clang-tidy. Curiously, some of them only show up with #148, which consumesabseil-cppdifferently.