Update build settings to let contributors build - #180
Draft
kenrachynski wants to merge 4 commits into
Draft
kenrachynski wants to merge 4 commits into
kenrachynski wants to merge 4 commits into
Conversation
Author
|
This may address parts of #172 |
kenrachynski
force-pushed
the
update-building
branch
2 times, most recently
from
September 1, 2026 01:35
c333737 to
4ec225f
Compare
Xcode *will* error out with the defaults originally in the files. I made these changes and Xcode was able to successfully build Relay.
Instrument Relay and RelayKit for plists containing the developer group id. Change swift code to read from plist instead of hard-coded group id.
Move CODE_SIGN_STYLE and CODE_SIGN_IDENTITY into Secrets.xcconfig so contributors without a paid Developer Program membership can build and run the app using a free Personal Team. Also wire RelayShareExtension to Secrets.xcconfig, which it was previously missing entirely. Relay's app sandbox and app group entitlements require a real development certificate and cannot be ad-hoc signed, so a free Apple ID is documented as the minimum requirement in CONTRIBUTING.md and Secrets.xcconfig.example. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
kenrachynski
force-pushed
the
update-building
branch
from
September 23, 2026 19:56
4ec225f to
1529e0f
Compare
kenrachynski
marked this pull request as draft
September 24, 2026 00:29
subpop
requested changes
Sep 24, 2026
Owner
There was a problem hiding this comment.
This file doesn't need to be here, and the references in the Xcode project can be dropped too. (I think if you git rm the file, Xcode notices and removes the file references.
Author
There was a problem hiding this comment.
Actually, it contains data specifically for developer identification.
Comment on lines
-13
to
+9
| <string>group.46UKXDYHHC.app.subpop.Relay</string> | ||
| <string>group.$(DEVELOPMENT_TEAM).$(BUNDLE_PREFIX).Relay</string> |
Owner
There was a problem hiding this comment.
This is the only change that should be present in this file. The rest are needlessly moving lines around.
Author
There was a problem hiding this comment.
Needless or not, I thought Xcode changed that file.
Owner
|
Overall, this works. I just have two changes I'd like to make, but I tested this locally and it still works for me with my |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xcode will error out with the defaults originally in the files. I made these changes and Xcode was able to successfully build Relay.
I have not tested a scenario where the person building the app does not have a developer account.