Repository navigation
refactor: remove @override from Command.run() implementations - #3128
Merged
Merged
Conversation
Member
Author
|
Didn't mean to auto-merge. Forgot that PRs don't require review here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another step towards replacing our bundled stubs with the public
sublime-text-stubspackage. Unlike our bundled stubs, that package doesn't declarerun()onsublime_plugin.Commandor its subclasses, because each command defines its own signature. With those stubs,@overrideon arun()method fails the type check because there is no base method to override.This removes
@overridefrom the tworun()methods that have it:LspTextCommandWithTasks.run()inplugin/lsp_task.pyLspSaveAllCommand.run()inplugin/save_command.pyThere is no runtime change.
Testing:
toxpasses against the current bundled stubs.