Repository navigation
Skip the whole SingleDocumentTestCase3 class - #3108
Merged
Merged
Conversation
Its only test is skipped, but setUpClass still ran, opened testfile2.txt and started a test server. No test closed that view, so it stayed open until the end of the run.
rchl
force-pushed
the
test/skip-whole-flaky-class
branch
from
October 31, 2026 20:31
ee86487 to
1f62063
Compare
Member
|
Is this PR needed now when the unit testing PR SublimeText/UnitTesting#309 is merged? |
Member
Author
|
It still makes sense to not open a file if the test is skipped. Regardless if it causes any issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SingleDocumentTestCase3has a single test, which is skipped.unitteststill runssetUpClassfor a class whose tests are all skipped, so it openedtestfile2.txtand started a test server for nothing. Since no test ran, no cleanup closed that view and it stayed open until the end of the run.Skipping the class instead skips
setUpClassandtearDownClasstoo.Found while investigating a local-only failure of
test_documents.py::test_sends_did_open_to_multiple_sessions. The root cause of that failure is in the UnitTesting Docker runner, which restored views from the previous run's saved session: SublimeText/UnitTesting#309. This PR only removes one source of those views.mainhas the same skipped class.