Remove old regex-style Slack token DLP rule - #5285
Open
randypargman wants to merge 2 commits into
Open
Conversation
… Slack access token Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Shared Samples Sync - Action RequiredThis PR was not automatically synced to shared-samples because the author is not a member of the To enable syncing, an organization member can comment Once triggered, the rules will be synced on the next scheduled run (every 10 minutes). |
Jummyberry
approved these changes
Sep 5, 2026
Jummyberry
left a comment
Contributor
There was a problem hiding this comment.
Verified that beta_dlp_slack_access_token (ML recognizer-based rule) is active and covers the same detection surface as the old regex rule. Ran the old regex pattern as a hunt against shared samples 0 hits, confirming no active detection is being lost with this removal. Approving
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dlp_slack_token.yml, the old regex-based Slack token detection ruleTest plan