Skip to content

Fix flaky up --wait failure on bucket-creation exit #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thunderkatz merged 2 commits into from
Sep 8, 2026
Merged

Fix flaky up --wait failure on bucket-creation exit #269

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
914afde
Add sentinel dependent so up --wait doesn't fail on bucket-creation exit
thunderkatz Sep 8, 2026
fe6d3df
Use tail -f /dev/null for the storage-ready sentinel
thunderkatz Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,21 @@ services:
/usr/bin/mc mb --ignore-existing myminio/nipper-artifacts &&
/usr/bin/mc ls myminio;
"
# docker compose up --wait treats any container it doesn't already expect to exit as failed the
# moment it exits, even with code 0 (https://github.com/docker/compose/issues/10596). Neither
# sublime_create_buckets nor sublime_create_azure_blob_containers has a dependent declared with
# condition: service_completed_successfully, so --wait has no way to know their exit is expected.
# This long-running sentinel supplies that dependent so --wait treats their completion as success.
sublime_storage_ready:
image: alpine:3.20
command: ["tail", "-f", "/dev/null"]
networks:
- net
depends_on:
sublime_create_buckets:
condition: service_completed_successfully
sublime_create_azure_blob_containers:
condition: service_completed_successfully
sublime_hydra:
image: sublimesec/hydra-cpu:dev
restart: unless-stopped
Expand Down
Loading