Add file_hashes_image_warning_banners.txt - #873
Merged
Merged
Conversation
…o email by 3rd party systems to warn recipients
zoomequipd
reviewed
Sep 8, 2026
Comment on lines
+99
to
+104
| "file": "file_hashes_image_warning_banners.txt", | ||
| "identifier": "file_hashes_image_warning_banners", | ||
| "display_name": "File hashes of images added to messages by 3rd party systems to warn recipients.", | ||
| "headers": [ | ||
| "entry" | ||
| ] |
Member
There was a problem hiding this comment.
indentation doesn't match the other entries
Suggested change
| "file": "file_hashes_image_warning_banners.txt", | |
| "identifier": "file_hashes_image_warning_banners", | |
| "display_name": "File hashes of images added to messages by 3rd party systems to warn recipients.", | |
| "headers": [ | |
| "entry" | |
| ] | |
| "file": "file_hashes_image_warning_banners.txt", | |
| "identifier": "file_hashes_image_warning_banners", | |
| "display_name": "File hashes of images added to messages by 3rd party systems to warn recipients.", | |
| "headers": [ | |
| "entry" | |
| ] |
zoomequipd
reviewed
Sep 8, 2026
Member
There was a problem hiding this comment.
might be worth including that it's the sha256 of the file somewhere, not sure where. if it's the list name, or the manifest description.
zoomequipd
approved these changes
Sep 8, 2026
zoomequipd
left a comment
zoomequipd
left a comment
Member
There was a problem hiding this comment.
non-blocking feedback provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a list of sha256 hashes of image files added to email by 3rd party systems to warn recipients.
It can be used to differentiate attachments added by a 3rd party system from attachments that were present in the original email from the sender.
This is a useful differentiation to express detection logic that considers the number of attachments.