Conversation
Close the silent-blank flatten hole by flattening transparency-normal-cmyk through PDFTransparencyFlattener::apply(), re-rendering at 128x128, and comparing to a committed PNG plus measurement budgets on UnitTestsOverprintRender. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
mberrys
marked this pull request as ready for review
September 15, 2026 20:56
- Map UnitTests/tst_overprintrendertest.cpp into the core agent-policy path set so edits select UnitTestsOverprintRender in PR CI. - Assert catalog presence before dereferencing a missing flatten fixture. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review follow-ups
Addresses blocking merge-gate feedback:
UnitTests/tst_overprintrendertest.cppto the core module path map inagent-policy.jsonso edits to this test automatically selectUnitTestsOverprintRenderin PR CI.flattenThenRendernow assertsdocument.getCatalog()before dereferencinggetPage(0)when a fixture is missing or unreadable.Local verification:
UnitTestsOverprintRenderpassed (including the new flatten-then-render golden).Scope note: The committed golden is regression proof against blank-raster flatten success, not independent general flatten-fidelity proof.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.