Add Loop UI design system tokens, state mapping, and non-color cues (#194) - #547
Merged
Conversation
…ues (#194) Continue PR #525 on current origin/dev. Shared pdfquick::tokens cover spacing, typography, focus geometry, and colour roles; resolveStateVisual() is the canonical finding/check mapping. Incomplete and waived states never resolve as passed, and each state carries a unique icon plus accessible name. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
Co-authored-by: michael berry <mberrys@users.noreply.github.com>
Qt::red against white is only ~4.0:1. Use the light-theme fill (#B91C1C) so a destructive button label still meets WCAG text contrast in high contrast. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
Drop restated enum notes, unused includes, and CMake/doc padding. Mapping invariants stay in tests and LOOP_DESIGN_SYSTEM.md. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
mberrys
marked this pull request as ready for review
September 7, 2026 21:24
Co-authored-by: michael berry <mberrys@users.noreply.github.com>
Resolve conflicts after PR #525 landed on dev by keeping the expanded design-system implementation from this branch and merging the dev-side UnitTestsLoopStateVisual CMake commentary. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
The merge from origin/dev added UnitTestsLoopStateVisual without refreshing the generated inventory (70 -> 71 targets). Policy and source_integrity both fail when phase5-widgets-inventory.json is stale. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerates
docs/generated/phase5-widgets-inventory.jsonafter theorigin/devmerge. The merge addedUnitTestsLoopStateVisual(71 targets, was 70) without refreshing the generated inventory, which caused policy (×2) and source_integrity to fail on "Verify Phase 5 Widgets evidence is current".Continues MB-460 / #194 design-system work from PR #525.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.