-
Notifications
You must be signed in to change notification settings - Fork 0
feat(preflight): judge white overprint and transparency interaction on the compositor (#119) #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e9bec03
test(preflight): add clipped off-page and obscured-content regression…
mberrys 9bfd801
feat(preflight): judge off-page and obscured content on clipped paint…
mberrys c69414f
test(preflight): span the page in the off-page clip regression case (…
mberrys 5ae8baa
docs(preflight): land off-page-content-clipping and obscured-content-…
mberrys 994e89d
test(preflight): add compositor-authority white-overprint and transpa…
mberrys 249444a
feat(preflight): judge white overprint and transparency interaction o…
mberrys c63055e
fix(preflight): count only real transparency as overprint interaction…
mberrys 705a04e
docs(preflight): land white-overprint-renderer and transparency-rip-i…
mberrys 4fa8558
style(preflight): clang-format the files touched for the compositor p…
mberrys 32f03dd
perf(preflight): track occlusion only for obscured-content
mberrys 998bbbf
fix(preflight): key compositor probes by dpi and scan nested overprint
mberrys 6ce3659
Merge #159 (issue-118 clip-aware geometry) into issue-119 branch
claude 73bb522
Merge dev into issue-118 branch
claude 2c3f618
Merge issue-118 branch (with dev) into issue-119 branch
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This duplicates
PDFInkCoverageProbe::probe. About 50 lines are copied: box resolution, size and budget check, renderer settings, ink mapper and renderer construction. A shared "render page on the compositor" helper would keep the two probes from drifting apart.evaluateWhiteOverprintOnCompositorandevaluateTransparencyOverprintOnCompositorare also near-identical loops.