Conversation
#116) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…116) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…and evidence (#116) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…116) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
mberrys
commented
Oct 1, 2026
| continue; | ||
| } | ||
|
|
||
| if (check.minRegionAreaMm2 < result.minResolvableAreaMM2) |
Contributor
Author
There was a problem hiding this comment.
Incomplete finding is emitted on every page, even when nothing is over the limit. The schema says an over-limit region the raster cannot resolve makes the check incomplete. This branch instead fires whenever the floor is below the raster resolution, even with overLimitAreaMM2 == 0. With min_region_area_mm2: 0 (allowed by the schema) every page of a clean document is reported incomplete. Gate it on the page actually having over-limit pixels.
… ink The coarse-probe incomplete finding fired on every page whenever the floor was below raster resolution, even on pages with no over-limit pixels. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #116 (L01-11).
ink-coverageno longer suppresses over-limit regions below a percentage of the page. The floor is now physical:min_region_area_mm2(default 0.25 mm², about a 0.5 mm square, the smallest solid a press reproduces as a distinct area). Aprobe_dpitoo coarse to resolve that floor (fewer than four raster pixels) reports the pagecheck-incompleteinstead of passing clean.min_region_area_pctis deprecated, still accepted, and ignored.Proof
Source SHA under test: head of
cc/issue-116-ink-coverage-floor. Fixtureloop-preflight/testdata/fixtures/ink-coverage-isolated-region.pdf(generatorloop-preflight/tools/generate_ink_isolated_region_fixture.py) is one 6 mm square of 400% rich black on an A3 page (about 0.03% of the page), committed first (126daa5).PdfTool preflight,test-ink-coverage.json)pass: true, 0 errors, 0 warningsink-coveragewarning: 38.2 mm², peak 400%The baseline
PdfToolwas built from the #157 head, which does not touch ink-coverage code.Local (Windows, MSVC Release):
UnitTestsPreflightEngine,UnitTestsPreflightCorpus,UnitTestsPreflightVerdict,UnitTestsPreflightChecks,UnitTestsEvidenceGraph,UnitTestsContentProcessorLimitsall exit 0. Regenerating the corpus snapshots changed only the newink-coverage-isolated-region.json(other differences were line endings).generate-architecture-catalogs.py --check,check_source_integrity.py,check_preflight_truth_source.pyandcheck-change.py --dry-runpass. New tests cover the isolated region on a large page, the deprecated percentage floor no longer suppressing it, an unresolvable floor reporting incomplete, andmin_region_area_mm2validation.Not run locally
Full
check-changebuild/ctest/clang-tidy (noclang-tidy-18), Linux lanes, and the remaining mapped test targets; left to CI.Remaining risk
min_region_area_pctto hide small regions will now see them.Handoff
Changed: probe and engine (
pdfinkcoverageprobe.*,preflightengine.*), schema, example and test profiles, README, overlay (ink-coverage-raster-taclanded, closed_byink-coverage), regenerated catalogs, fixture, generator, snapshot, change record and evidence. Anti-slop review: the physical floor replaces the percentage rather than adding a second knob, and the incomplete path fires only when the raster cannot resolve the configured floor.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.