Skip to content

Haploid geno - #64

Open
jydu wants to merge 10 commits into
stschiff:masterfrom
jydu:haploid-geno
Open

Haploid geno#64
jydu wants to merge 10 commits into
stschiff:masterfrom
jydu:haploid-geno

Conversation

@jydu

@jydu jydu commented Feb 23, 2026

Copy link
Copy Markdown

Hi Stephan,

I modified the multiHepSep file to work with haploid genomes. One just has to add the --haploid argument, and it will read only the first genotype (and consider it "phased").
I have not tried in combination with the trios option... I doubt it makes sense; one should probably add a test so that both are not used simultaneously.

Cheers,

Julien.

@stschiff

stschiff commented Mar 5, 2026

Copy link
Copy Markdown
Owner

OK, I looked through the code. Looks all reasonable. Have you tested it with toy data? If so, do you think you can perhaps add some test data into this repo, perhaps into a new folder testData and a readme on how to test it? I don't need to go full-scale unit-testing here, but with more contributors it probably makes sense to establish some simple non-automatic tests so that one can at least try it out in a minimal way. Thanks!

@jydu

jydu commented Mar 5, 2026

Copy link
Copy Markdown
Author

Hi Stephan, I tested it on real data, but it is unpublished. But I can make a test, for instance splitting a human phased diploid into haploids, and show that it give the same results... I put it on the TODO list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants