Column major fix of apply markers bc - #348
Open
max-models wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
self._eta_bc_buf = xp.zeros((self.n_rows, 3))buffer_find_outside_particles(axis, eta=None)now optionally reads from this small contiguous (n_rows, 3) buffer instead of striding a single column out of the full row-major markers array.apply_kinetic_bcnow does oneself._eta_bc_buf[:] = self.markers[:, :3]copy per BC-type block (only when that axis list is non-empty), then passeseta=self._eta_bc_bufinto every_find_outside_particlescall in that block. The buffer is refreshed fresh at the start of each block.Measured the improvement to be approximately 1.3x speedup, not huge but not too bad.
Merge after #347