Repository navigation
feat!: plan racks, cabling and replacements - #43
Merged
Merged
Conversation
Add typed physical definitions, rack elevations, cable ends and authorized paged projections over the existing inventory. Use shared plans, requirements and atomic reservations for installation, materials, replacement review and recoverable partial manual outcomes. Preserve unknown facts, surviving logical intent and unresolved physical work. Keep replacement decisions separate from mapping, identity and service evidence. Bound one-shot observation with source diagnostics and publish engineering and review guidance for data ownership, storage and contextual workflows. Closes #38 BREAKING CHANGE: Native collection source failures exit successfully without publishing a report. Callers must inspect the outcome and report existence. Invalid arguments, malformed frames and publication failures remain errors. Host Policy requires an explicit maximum duration for new physical reservations.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important Review skippedToo many files! This PR contains 111 files, which is 11 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.
 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3071e4f00
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Require empty-slot evidence only for structural positions while retaining shared-capacity admission. Recognize dedicated port containment as an owner/operator inheritance source. Supply measured outgoing service margins in the independent replacement fixture. Add disk-backed regressions for preview, reservation, completion and unchanged inheritance selections.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86fe9bc80f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Qualify component-owned ports through their accepted HasPort relation. Extend the disk-backed regression across component, port and dedicated logical endpoint, including unchanged source selection and both inherited facets. Provide explicit measured service clearances in the installation checkpoint browser fixture while retaining its prerequisite and postcondition assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Focused disk-backed physical and plan regressions, native macOS collection, warning-denied Clippy, formatting, generated contracts, Vue typechecking/builds and real desktop/phone Chromium workflows pass locally on macOS. Required CI runs the full workspace, alloc-only checks, native observation checks on macOS and Windows, and CodeQL.
Uses the explicit development fixture actor. Production authentication, provider execution and installable releases have separate qualification.
Replaces #42.
Closes #38
BREAKING CHANGE: Native collection source failures now exit successfully without publishing a report. Callers must inspect the collection outcome and report existence. Invalid arguments, malformed frames and file publication errors still return nonzero. Host Policy requires an explicit maximum duration for new physical reservations.