Repository navigation
Adds v2 check and error to top of SingletonAPIResource self.resource_url - #1992
Merged
Merged
Conversation
jar-stripe
marked this pull request as ready for review
October 6, 2026 17:44
jar-stripe
requested review from
mark-kogan-stripe
and
a balanced review from Copilot
and removed request for
a team
October 6, 2026 17:44
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The guard matches existing V2 behavior, with only a non-blocking regression-test suggestion remaining.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Aligns singleton resources with existing V2 resource behavior by rejecting legacy URL generation.
Changes:
- Raises
NotImplementedErrorfor V2 singleton URLs and directs callers toStripeClient. - Adds a patch release changelog entry.
| File | Description |
|---|---|
| lib/stripe/singleton_api_resource.rb | Adds the V2 URL guard. |
| .hark/changes/2026-10-06_jar_add-v2-condition-singleton-api-resource-resource-url.change.md | Records the behavior change. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jar-stripe
enabled auto-merge (squash)
October 6, 2026 19:20
zacchua-stripe
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
We are starting to see Singleton resources in v2. This fixes a gap in self.resource_url so that they behave like non-singleton v2 APIResource objects.
What?
See Also
https://go/j/DEVSDK-3327
Configuration
skip-changefile: This PR is not a user-facing change, so there's no changefile.