Repository navigation
Changes for upcoming major release - #1981
Merged
Merged
Conversation
jar-stripe
requested review from
justiny-stripe
and
a balanced review from Copilot
and removed request for
a team
September 29, 2026 16:51
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The migration guide’s documented API version does not match the SDK default, and the PR metadata incorrectly marks the changes as non-user-facing.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Prepares Stripe Ruby v20 by raising the minimum Ruby version and renaming the transfer reversal resource.
Changes:
- Requires Ruby 3.0+ and updates CI/tooling.
- Renames
Stripe::ReversaltoStripe::TransferReversal. - Adds release changefiles and migration guidance.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Removes Ruby 2.7 from CI. |
.hark/changes/2026-09-17_zacchua_rename-reversal-transferreversal.change.md |
Records the resource rename. |
.hark/changes/2026-09-25_unknown_drop-support-ruby-2-7.change.md |
Records Ruby 2.7 removal. |
.hark/migration-guides/v20.md |
Documents v20 migration steps. |
.rubocop.yml |
Targets Ruby 3.0 syntax. |
Gemfile |
Makes RuboCop unconditional. |
Makefile |
Always runs Sorbet. |
README.md |
Updates Ruby requirements. |
justfile |
Always runs Sorbet. |
lib/stripe/object_types.rb |
Maps transfer reversals to the renamed class. |
lib/stripe/resources.rb |
Registers the renamed resource. |
lib/stripe/resources/transfer_reversal.rb |
Renames the runtime class. |
lib/stripe/stripe_object.rb |
Updates Ruby compatibility guidance. |
rbi/stripe.rbi |
Updates aggregate Sorbet declarations. |
rbi/stripe/resources/balance_transaction.rbi |
Updates reversal source typing. |
rbi/stripe/resources/refund.rbi |
Updates refund reversal typing. |
rbi/stripe/resources/transfer_reversal.rbi |
Renames the resource declaration. |
rbi/stripe/resources/v2/deleted_object.rbi |
Normalizes formatting. |
rbi/stripe/services/transfer_reversal_service.rbi |
Updates service return types. |
stripe.gemspec |
Requires Ruby 3.0+. |
test/stripe/generated_examples_test.rb |
Renames example variables. |
test/stripe/stripe_object_test.rb |
Uses Ruby 3’s Hash#except. |
test/stripe/stripe_service_test.rb |
Uses argument forwarding syntax. |
test/stripe/transfer_reversal_test.rb |
Tests the renamed resource class. |
test/stripe/transfer_test.rb |
Updates reversal type assertions. |
test/stripe_mock.rb |
Freezes path constants. |
Files not reviewed (4)
- rbi/stripe.rbi: File type not supported
- rbi/stripe/resources/balance_transaction.rbi: File type not supported
- rbi/stripe/resources/refund.rbi: File type not supported
- rbi/stripe/services/transfer_reversal_service.rbi: File type not supported
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jar-stripe
force-pushed
the
sdk-release/next-major
branch
from
September 29, 2026 17:22
3983bfa to
3f24db6
Compare
* Generate Ruby TransferReversal rename Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Document TransferReversal migration Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Update TransferReversal tests Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Update migration guide --------- Co-authored-by: codex <noreply@openai.com> Co-authored-by: jar-stripe <jar@stripe.com>
*⚠️ Drop support for Ruby 2.7 Committed-By-Agent: goose Orbit-Session-Id: 46b49ea6-8080-4883-b500-9aeab03e14dc * Revise migration guide for SDK v20 Updated migration guide for v20 to reflect new API version and Ruby requirements.
Updated the class name and references for Stripe::Reversal.
jar-stripe
force-pushed
the
sdk-release/next-major
branch
from
September 29, 2026 17:52
5e56a40 to
3b484aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
What?
See Also
Configuration
skip-changefile: This PR is not a user-facing change, so there's no changefile.