Repository navigation
Workload Identities Node-AWS Pilot private preview - #2858
Open
mark-kogan-stripe wants to merge 21 commits into
Open
mark-kogan-stripe wants to merge 21 commits into
mark-kogan-stripe wants to merge 21 commits into
Conversation
…andle aws import for workload identity federation
mark-kogan-stripe
force-pushed
the
mark/DEVSDK-3242-privatepreview
branch
from
September 30, 2026 19:46
a5e2514 to
040e8bc
Compare
mark-kogan-stripe
force-pushed
the
mark/DEVSDK-3242-privatepreview
branch
from
September 30, 2026 19:49
040e8bc to
df3dc63
Compare
mark-kogan-stripe
force-pushed
the
mark/DEVSDK-3242-privatepreview
branch
from
September 30, 2026 20:54
30a197e to
c83d383
Compare
Co-authored-by: mark-kogan-stripe <322952142+mark-kogan-stripe@users.noreply.github.com>
mark-kogan-stripe
force-pushed
the
mark/DEVSDK-3242-privatepreview
branch
from
October 1, 2026 14:41
54c3ee5 to
7e93716
Compare
mark-kogan-stripe
force-pushed
the
mark/DEVSDK-3242-privatepreview
branch
from
October 2, 2026 18:24
431ba50 to
848e09f
Compare
mark-kogan-stripe
force-pushed
the
mark/DEVSDK-3242-privatepreview
branch
from
October 3, 2026 19:51
b1d68d7 to
071d447
Compare
mark-kogan-stripe
force-pushed
the
mark/DEVSDK-3242-privatepreview
branch
from
October 5, 2026 13:46
4955996 to
394024a
Compare
mark-kogan-stripe
marked this pull request as ready for review
October 5, 2026 17:29
mark-kogan-stripe
requested review from
jar-stripe and
justiny-stripe
and removed request for
a team and
justiny-stripe
October 5, 2026 17:29
jar-stripe
reviewed
Oct 9, 2026
jar-stripe
left a comment
Contributor
There was a problem hiding this comment.
Lotsa notes 😅 . I saw a couple of patterns around comments that could be cleaned up and checks for types/shapes that really should have been enforced by the type system. It's worth a cleanup pass and then another pass to see if theres anything else like this that i missed
| }); | ||
| } | ||
|
|
||
| const parsed = parseJsonOrNull(response.body); |
Contributor
There was a problem hiding this comment.
for a follow on ticket, its worth considering zod or runtypes for json validation here.
| ): Stripe { | ||
| validateWorkloadIdentityProvider(identityProvider); | ||
|
|
||
| if (config && typeof config !== 'object') { |
Contributor
There was a problem hiding this comment.
this check feels unnecessary; the type will does not allow a string form
jar-stripe
reviewed
Oct 9, 2026
…able, pull aws-wif package publishing into separate workflow, remove redundant tests and message truncation, fix error convention and improve docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
This PR introduces an alternate way to create a top-level Stripe client, authenticated via AWS instead of a long-lived API key. Rather than relying on a semi-permanent secret that can be leaked or mismanaged, the SDK fetches a short-lived token backed by a public key and the guarantee that the code is running on genuine cloud provider hardware.
The change adds a separate adapter package within this repo that uses the AWS SDK to build an assertion function capable of retrieving web identity tokens. The core stripe package then uses that assertion function to mint an ephemeral key, refreshing it proactively and also on a single 401 as a fallback, for the lifetime of the session. Once constructed, the resulting Stripe client behaves identically to a standard one.
What?
See Also
Configuration
skip-changefile: This PR is not a user-facing change, so there's no changefile.