feat: rename WPF editors projects - #3433
Kryptos-FR wants to merge 17 commits into
Conversation
|
Great, looking forward to have it merged so that it's easier for you! Question: should the current WPF project ends up keeping package ID to avoid churn on nuget.org? (keeping csproj name, or using either That way, no discontinuity on nuget.org. And once Avalonia is ready, we could delete WPF and adjust Avalonia ones without Avalonia suffix. Unless we want them side-by-side for a while? (in which case we really might want the Wpf suffix as well) |
|
We want them side by side for a while. In the next PR I will introduce new projects and some have the name of previous Wpf one, like Stride.Core.Assets.Editor. The idea is to separate code that is UI-agnostic (so most of the view models, quantum, assets and associated logic) and have only what is specific to WPF or Avalonia in their own projects. Initially I wanted to shared that logic between the two, but our current WPF projects are too intertwined. So far only Stride.Core.Presentation was cleanly split. In the future, if we change again to another UI framework (or even use our own), only the UI part will need to be reworked. |
|
OK, sounds good |
|
I think to avoid risks with upcoming release, I will soon fork |
|
yes, it's probably better to target a future version |
|
OK, I created |
|
Should be ok. Most conflicts were resolved automatically. |
|
Thanks! |
PR Details
WPF projects have been moved/renamed, adding a
Wpfsuffix to them (to both their folder and project file).Translation files have been refreshed (some locales had never been updated).
Note
For reviewers, the amount of files touched is huge. However, for most of them it is a simple rename without any content change. Consider focusing on the few files that do have soem changes.
Important
Before merging, all projects must compile, all tests must pass and project creation in the Game Studio should be tested.
Related Issue
Part of #3432
Types of changes
Checklist