Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ElementsMatch(t, [2]int{}, []int{})currently succeeds even though one collection contains two elements and the other contains none.NotElementsMatchgives the inverse wrong result, and comparing nil with a nonempty collection panics. These incorrect results can hide bugs in tests using zero-filled arrays.The general
Emptyassertion intentionally treats a zero-valued array as empty, but collection equality must count its elements. Remove that shortcut from the two collection assertions and let their existing list-diff owner handle nil as a zero-length list.Emptyitself and the public API remain unchanged.Validation with Go 1.26.0 on macOS arm64:
87a7b9d57689f6579db2da795ab8deeab29cb724, with wrong zero-array results and a nil-reflection panic.go test ./...andgo vet ./...pass.gofmtandgit diff --checkare clean.