Skip to content

feat: allow overriding S3 bucket names in dns-bucket module#185

Open
maxsxu wants to merge 1 commit intomasterfrom
max/add-bucket-name-overrides
Open

feat: allow overriding S3 bucket names in dns-bucket module#185
maxsxu wants to merge 1 commit intomasterfrom
max/add-bucket-name-overrides

Conversation

@maxsxu
Copy link
Copy Markdown
Member

@maxsxu maxsxu commented Apr 20, 2026

Motivation

Currently, S3 bucket names in the dns-bucket module are automatically generated based on the pm_name and pm_namespace. There are cases where users might want to use custom bucket names or match existing buckets. This change introduces override variables for Velero, Tiered Storage, and Loki buckets.

Modifications

  • Added velero_bucket_name, tiered_storage_bucket_name, and loki_bucket_name variables to modules/dns-bucket/variables.tf.
  • Updated aws_s3_bucket resources in modules/dns-bucket/bucket.tf to use coalesce with these new variables, defaulting to the existing generated names if the overrides are not provided.
  • Updated modules/dns-bucket/README.md using terraform-docs.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework allowing for more flexibility in naming.

Documentation

Check the box below.

Need to update docs?

  • doc-required

  • no-need-doc

    Variables are self-documented in Terraform and README has been updated.

@maxsxu maxsxu requested a review from a team as a code owner April 20, 2026 03:47
@github-actions github-actions Bot added the no-need-doc This pr does not need any document label Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-need-doc This pr does not need any document

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant