feat: allow overriding S3 bucket names in dns-bucket module#185
Open
feat: allow overriding S3 bucket names in dns-bucket module#185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, S3 bucket names in the
dns-bucketmodule are automatically generated based on thepm_nameandpm_namespace. There are cases where users might want to use custom bucket names or match existing buckets. This change introduces override variables for Velero, Tiered Storage, and Loki buckets.Modifications
velero_bucket_name,tiered_storage_bucket_name, andloki_bucket_namevariables tomodules/dns-bucket/variables.tf.aws_s3_bucketresources inmodules/dns-bucket/bucket.tfto usecoalescewith these new variables, defaulting to the existing generated names if the overrides are not provided.modules/dns-bucket/README.mdusingterraform-docs.Verifying this change
This change is a trivial rework allowing for more flexibility in naming.
Documentation
Check the box below.
Need to update docs?
doc-requiredno-need-docVariables are self-documented in Terraform and README has been updated.