feat: Allow setting the authentication_mode variable#184
Open
mitch-hamm wants to merge 2 commits intomasterfrom
Open
feat: Allow setting the authentication_mode variable#184mitch-hamm wants to merge 2 commits intomasterfrom
mitch-hamm wants to merge 2 commits intomasterfrom
Conversation
Contributor
|
@mitch-hamm:Thanks for your contribution. For this PR, do we need to update docs? |
Contributor
|
@mitch-hamm:Thanks for providing doc info! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The aws-auth config map is a legacy feature for cluster authentication. The new approach is outlined and features are described here: https://docs.aws.amazon.com/eks/latest/userguide/access-entries.html#_features
We should allow setting this parameter to have more fine grained control over the migration process from legacy to API control.
The API mode will also give better control to avoid cluster lockouts due to a misconfigured aws-auth config map
As per: https://registry.terraform.io/modules/terraform-aws-modules/eks/aws/20.29.0?tab=inputs
The default is
API_AND_CONFIG_MAPModifications
Add var for configuration of the authentication_mode and set the default as
API_AND_CONFIG_MAPVerifying this change
This change added tests and can be verified as follows:
API_AND_CONFIG_MAPand switch after creation toAPIAPIand verify successful creation and functionalityDocumentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)