Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the Pulsar admin MCP tool surface (feature flags, operation names, and supported capabilities) more closely with pulsarctl, while adding missing admin operations and updating documentation/tests to match.
Changes:
- Adds new Pulsar admin capabilities (broker/proxy status checks, topic permission management, subscription peek/message-by-id, function package upload/download).
- Renames/realigns Pulsar feature flags and operation names to match
pulsarctlconventions (with legacy alias support in key places). - Expands unit/parity tests and updates
docs/tools/*plusREADME.mdfeature listings accordingly.
Reviewed changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates the feature-flag catalog for renamed/new Pulsar admin tool groups. |
| pkg/pulsar/connection.go | Exposes a safe accessor for the underlying pulsarctl cluster config (copy). |
| pkg/mcp/pulsar_admin_status_tools.go | Registers the new status tool builder with the MCP server. |
| pkg/mcp/features.go | Adds/aligns feature constants for updated Pulsar admin tool gating. |
| pkg/mcp/builders/pulsar/topic.go | Adds topic permission operations, compact-status aliasing, and optional wait/polling. |
| pkg/mcp/builders/pulsar/topic_test.go | Adds unit coverage for new topic operations/aliases/read-only constraints. |
| pkg/mcp/builders/pulsar/topic_policy.go | Major parity expansion/rename of topic-policy operations and parameters. |
| pkg/mcp/builders/pulsar/topic_policy_test.go | Adds tests for topic-policy operation normalization and new params. |
| pkg/mcp/builders/pulsar/subscription.go | Adds peek and get-message-by-id, plus shared parsing helpers. |
| pkg/mcp/builders/pulsar/subscription_test.go | Adds tests for new subscription operations and helper parsing. |
| pkg/mcp/builders/pulsar/status.go | Implements broker/proxy status check via /status.html. |
| pkg/mcp/builders/pulsar/status_test.go | Adds feature-gate + handler error-path coverage for status tool. |
| pkg/mcp/builders/pulsar/resourcequotas.go | Aligns feature gate name for resource quotas tools. |
| pkg/mcp/builders/pulsar/nsisolationpolicy.go | Aligns feature gate name for namespace isolation policy tools. |
| pkg/mcp/builders/pulsar/namespace_policy.go | Extends namespace policy set/remove support and adds anti-affinity lookup tool. |
| pkg/mcp/builders/pulsar/namespace_policy_test.go | Adds tests for new namespace policy tooling and helpers. |
| pkg/mcp/builders/pulsar/functions.go | Adds function package download/upload operations and operation validation helpers. |
| pkg/mcp/builders/pulsar/functions_parity_test.go | Adds parity tests for file-transfer operations and download target parsing. |
| pkg/mcp/builders/pulsar/feature_gates_test.go | Adds feature-gate regression tests for renamed gates. |
| pkg/mcp/builders/pulsar/brokers_stats.go | Aligns broker-stats feature gate to its own feature flag. |
| pkg/mcp/builders/pulsar/brokers_stats_test.go | Adds feature-gate tests for broker-stats. |
| pkg/cmd/mcp/server.go | Wires the new Pulsar admin status tools into server bootstrap. |
| docs/tools/pulsar_admin_topics.md | Documents new topic permission ops and compact-status + wait. |
| docs/tools/pulsar_admin_topic_policy.md | Rewrites docs to match new pulsarctl-aligned topic-policy ops/params. |
| docs/tools/pulsar_admin_subscriptions.md | Documents new subscription ops and corrected argument names. |
| docs/tools/pulsar_admin_status.md | Documents the new pulsar_admin_status tool. |
| docs/tools/pulsar_admin_namespace_policy.md | Updates namespace policy docs for new tools/parameters/policies. |
| docs/tools/pulsar_admin_functions.md | Documents new function package download/upload operations. |
| .github/copilot-instructions.md | Adds repo-specific Copilot workflow/architecture guidance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 29 out of 29 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jiangpengcheng
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.