Repository navigation
feat(helm): support Cloud configuration and finalizer permissions - #853
Closed
labuladong wants to merge 2 commits into
Closed
labuladong wants to merge 2 commits into
labuladong wants to merge 2 commits into
Conversation
Allow Cloud consumers to configure operator environment references, CRD retention annotations and the cert-manager certificate subject without patching the chart. Preserve default rendering and regenerate the annotations with CRD templates. Co-authored-by: Codex <codex@openai.com>
|
@labuladong:Thanks for your contribution. For this PR, do we need to update docs? |
Match the controller RBAC markers and published OLM bundle for Function, Source and Sink finalizer reads and updates. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloud's direct operator installation needs to preserve its environment settings and retain CRDs when an Argo Application is removed. Expose
controllerManager.extraEnv/extraEnvFrom,admission-webhook.admissionWebhook.crdAnnotations, and an optional cert-manager certificate Common Name, so consumers can configure these through values without patching the upstream chart. Include the annotation block in the CRD template generator. Restore the Function/Source/Sink finalizerget/updatepermissions already declared by the controller RBAC markers and granted by the published OLM bundle.Related to SNIP-176 and product-roadmap#1460. Cloud values and infrastructure wiring are separate follow-ups.
Validation:
get/update; the optional configuration fields are no-ops by default.git diff --checkpass.No operator code or runtime defaults change. No cluster deployment was performed.