Skip to content

fix: missing aria label in nav elements - #166

Open
matej-marcisovsky wants to merge 1 commit into
stagingfrom
147-axe-navigation-landmarks-have-no-accessible-names
Open

matej-marcisovsky wants to merge 1 commit into
stagingfrom
147-axe-navigation-landmarks-have-no-accessible-names

Conversation

@matej-marcisovsky

@matej-marcisovsky matej-marcisovsky commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Task Link

#147

Description

Unnamed

elements on the same page all announced as "navigation", so Axe landmark-unique failed. Each one now has an aria-label from landmarks in en.json:

Main navbar: "Main"
Blog categories: "Blog categories"
Table of contents and component-library links: "On this page"
Footer columns: "Footer: {title}", or "Footer 1", "Footer 2", … when a column has no title
data-navbar is unchanged, so existing Playwright selectors still work. QA can later switch to getByRole("navigation", { name: "Main" }) and getByRole("navigation", { name: "Blog categories" }).

Checklist - author

  • Assignee is set (the active developer of this PR).
  • Reviewers are set (team members who will review the code).
  • PR is linked I have linked the PR to an issue in Jira.
  • Description I have described the changes proposed in the PR clearly and concisely (more important than what is why).
  • Screenshots/Videos I have added screenshots/videos or they were not needed.
  • Environmental variables are listed or they were not needed.
  • Unit/Integration tests are added for all utilities and business important logic
  • Labels I have added labels to the PR.
    • Use requires-env-vars when PR requires environmental variables
    • Use ready-for-review when PR is ready to be looked at
    • Use ready-to-merge when PR has a passing review
    • Use needs-revisions when PR has comments that block merge
    • Use do-not-review when PR is daft only and you don't want to get a review
  • [OPTIONAL] Conversation/documentation is started in places where the code is not self-explanatory

Before merging

  • PR is approved
  • All conversations are resolved
  • Pipelines are not failing

Checklist - reviewer

  • I understand all proposed changes.
  • Necessary after deploy steps are handled by someone (adding new env var, syncing config, running migration...)

@matej-marcisovsky matej-marcisovsky self-assigned this Oct 27, 2026
@vercel

vercel Bot commented Oct 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
website-ui Ready Ready Preview Oct 27, 2026 12:07pm UTC

Request Review

This branch was successfully deployed

1 active deployment
Preview — ecede791 Deployed Oct 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant