Repository navigation
chore(tooling): remove changesets, use the client workflow for releases - #245
Draft
innerdvations wants to merge 3 commits into
Draft
innerdvations wants to merge 3 commits into
innerdvations wants to merge 3 commits into
Conversation
Remove Changesets so a maintainer bumps the version and the Release workflow publishes with npm trusted publishing.
|
prepack runs the unit tests during npm publish. The Release workflow uses Node 22, where a reused Jest worker throws "import after teardown".
SonarCloud fails the new-code security rating when the release workflow uses floating tags for the pnpm and Slack actions.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




What does it do?
Removes Changesets and publishes
@strapi/sdk-pluginthe same way@strapi/clientdoes..changeset/, the Changesets dependencies, and therelease:*/prerelease:*scripts.mainChangesets action with a manually run Release workflow. A maintainer bumpspackage.jsonon areleases/<version>branch, tags that commit, and runs the workflow with thelatestornextdist-tag. The workflow builds, then runsnpm publish --provenance --access public.prepackruns format, lint, types, unit tests, and the build before publish. That is the check@strapi/clientruns from itsprepackscript. This package did not have one.CONTRIBUTING.md. Creating the git tag and the GitHub Release stays manual, same as client.Pending Changesets files on
mainare removed. They described changes already committed sincev6.1.1. The next GitHub Release should use generated notes.Why is it needed?
@strapi/sdk-pluginis one package. Changesets required a changeset file on each change, and missed files had to be backfilled.@strapi/clientalready publishes from a manually run workflow with npm trusted publishing.How to test it?
.changeset/is gone andpackage.jsonhas no@changesets/*dependency.6.1.1, and a run would try to publish that version again.Related issue(s)/PR(s)
Fixes CMS-1994
#177 is the open Changesets version PR (
changeset-release/main). Close it when this merges so it cannot version the package with Changesets again.Secrets and npm access
Set this before the first release:
SLACK_RELEASE_WEBHOOK_URLonstrapi/sdk-plugin. This is a repository Actions secret: a Slack incoming webhook.strapi/clientalready has this secret, and its Release workflow posts success and failure with it. This repo does not have it. The publish job can still succeed; the Slack jobs fail until the secret exists.No other new GitHub secret is required.
NPM_TOKENis already set on this repo (updated 2026-05-20). This workflow does not read it.strapi/clienthas noNPM_TOKENsecret. Publish uses npm trusted publishing (OIDC,id-token: write).@strapi/sdk-pluginmust allow repositorystrapi/sdk-pluginand workflow.github/workflows/release.yml. That setting lives on npmjs.com, not in GitHub secrets. feature: adding trusted publishing #185 already used this workflow filename for trusted publishing. Confirm the publisher is still saved for that file. CMS-1372 is still in Backlog, so the npmjs.com publisher may never have been saved. If it is missing, add a trusted publisher for this repository and.github/workflows/release.yml. The workflow does not use a GitHub environment, so leave the publisher environment empty.