Skip to content

fix(sync): isolate existing PR lookup from owner PAT quota #3153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stranske merged 2 commits into from
Aug 21, 2026
+8 −1
Merged

fix(sync): isolate existing PR lookup from owner PAT quota #3153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
610d98e
fix(sync): isolate existing PR lookup from owner PAT quota
codex-automation Aug 21, 2026
bcf5fd1
fix(sync): grant app token PR read access
codex-automation Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/maint-68-sync-consumer-repos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,7 @@ jobs:
owner: ${{ steps.repo_meta.outputs.repo_owner }}
repositories: ${{ steps.repo_meta.outputs.repo_name }}
permission-contents: write
permission-pull-requests: read
permission-workflows: write

- name: Checkout Workflows
Expand Down Expand Up @@ -979,7 +980,11 @@ jobs:
env:
SYNC_BRANCH: ${{ needs.prepare.outputs.sync_branch }}
with:
github-token: ${{ env.REPO_TOKEN }}
# The owner PAT is used for consumer writes below and can be depleted by
# unrelated fleet activity. This read is safe for the freshly minted,
# consumer-scoped Workflows App token, which keeps a rate-limited owner
# PAT from preventing an existing stable delivery PR from being found.
github-token: ${{ steps.workflows_app_token.outputs.token }}
Comment thread
stranske marked this conversation as resolved.
Comment thread
stranske marked this conversation as resolved.
script: |
const { isConsumerOpenPr } = require('./workflows/.github/scripts/sync_tracker_state');
const branchName = process.env.SYNC_BRANCH;
Expand Down
2 changes: 2 additions & 0 deletions tests/workflows/test_sync_manifest_delivery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,7 @@ def test_sync_fanout_is_canary_gated_and_promotion_is_plan_bound() -> None:
assert 'sync_branch="sync/workflows-candidate"' in source
assert 'sync_branch="sync/workflows-delivery"' in source
assert "const branchName = process.env.SYNC_BRANCH;" in source
assert "github-token: ${{ steps.workflows_app_token.outputs.token }}" in source
assert 'branch_name="$SYNC_BRANCH"' in source
assert "stable_plan_rotation" in source
assert "expectedStableBranch" in source
Expand Down Expand Up @@ -589,6 +590,7 @@ def test_maint68_reuses_stable_delivery_pr_without_resetting_an_unchanged_head()
)
assert "actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3" in source
assert "permission-contents: write" in source
assert "permission-pull-requests: read" in source
assert "permission-workflows: write" in source
assert "gh api" not in source
assert 'git config user.name "github-actions[bot]"' not in source
Expand Down
Loading