utils: Fail early when calling bd_utils_resolve_device with NULL

[vojtechtrefny]

gcc static analyzer is complaining about this and the produced error in case is quite cryptic.

Summary by CodeRabbit

• Bug Fixes
  • Enhanced input validation in device utilities to properly handle invalid inputs and improve system stability.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c7278f2b-fab8-4dc0-98d2-7457f807600d

📥 Commits

Reviewing files that changed from the base of the PR and between 454ce04 and 578b28a.

📒 Files selected for processing (1)

• src/utils/dev_utils.c

---

📝 Walkthrough

Walkthrough

The bd_utils_resolve_device function in dev_utils.c now includes input validation that checks if the dev_spec parameter is NULL. When NULL is detected, the function sets a GError and returns NULL, preventing further device resolution logic from executing.

Changes

Cohort / File(s)	Summary
Input Validation src/utils/dev_utils.c	Added NULL check for dev_spec parameter in bd_utils_resolve_device function; sets GError with domain BD_UTILS_DEV_UTILS_ERROR and code BD_UTILS_DEV_UTILS_ERROR_FAILED before returning NULL.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and clearly describes the main change: adding NULL validation to bd_utils_resolve_device to fail early with a proper error message.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 0/1 reviews remaining, refill in 60 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}