Skip to content

fix: graciouslyFetch returns undefined on network error, crashes updates_for callers #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JeremiahChurch wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: graciouslyFetch returns undefined on network error, crashes updates_for callers #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
770d9ca
fix: graciouslyFetch returns undefined on network error, crashes upda…
JeremiahChurch Apr 1, 2026
c8d20ea
style: apply prettier-standard formatting to changed files
JeremiahChurch Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions javascript/elements/updates_for_element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export default class UpdatesForElement extends SubscribingElement {
const response = await graciouslyFetch(url, {
'X-Cable-Ready': 'update'
})
this.html[url] = await response.text()
if (response) this.html[url] = await response.text()
}
})
)
Expand Down Expand Up @@ -254,7 +254,8 @@ class Block {
)

const frameTemplate = document.createElement('template')
frameTemplate.innerHTML = await frameResponse.text()
if (frameResponse)
frameTemplate.innerHTML = await frameResponse.text()

// recurse here to get all nested eager loaded frames
await this.resolveTurboFrames(frameTemplate.content)
Expand Down
11 changes: 9 additions & 2 deletions javascript/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,15 @@ function safeObject (obj) {

function safeStringOrArray (elem) {
if (elem !== undefined && !Array.isArray(elem) && typeof elem !== 'string')
console.warn(`Operation expects an Array or a String, but got ${elem} (${typeof elem})`)
console.warn(
`Operation expects an Array or a String, but got ${elem} (${typeof elem})`
)

return elem == null ? '' : Array.isArray(elem) ? Array.from(elem) : String(elem)
return elem == null
? ''
: Array.isArray(elem)
? Array.from(elem)
: String(elem)
}

function fragmentToString (fragment) {
Expand All @@ -202,6 +208,7 @@ async function graciouslyFetch (url, additionalHeaders) {
return response
} catch (e) {
console.error(`Could not fetch ${url}`)
return new Response('')
}
}

Expand Down