docs: v4 migration & architecture plan#1169
Merged
Merged
Conversation
…onfigWriteUser preset
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
docs/V4-MIGRATION-PLAN.md— the agreed plan and architecture forsimple-git@4, to act as the living reference for the stacked PRs landing oncanary/v4.Covers
publish→publishConfig; dropbuild:pkg+devtools/package-json.ts; remove all babel incl.@simple-git/babel-config.mock-child-processmigration).es/cjs/umd) with thelegacyExportFormatplugin so the CJS bundle supports bothrequire('simple-git')and{ simpleGit } = require('simple-git').simple-git/promise+gitP; trailing callback arguments (replaced by a loud throw guard pointing at the upgrade doc).{ commands, format, parser, onError? }); newgit.run/git.raw/git.stream; existing methods retained as thin wrappers; newsimple-git/taskssubpath; co-located per-task types.run<R>(...tasks: [...GitTask<unknown>[], GitTask<R>]): Promise<R>— infers the result from the last task (noany).rawkeeps a backward-compatible trailing-Optionsoverload with a zero-length string prefix.GIT_*/GitEnvKeysunless allow-listed viaallowEnvironment, built at spawn time so the task fails — not.env()); deny-by-default git config writes viaallowConfigWrite(wildcards), with spreadable convenience presets (e.g.allowConfigWriteUser) — nothing bypasses the allow-list.Docs-only; no code changes.
Generated by Claude Code