Skip to content

improved speed through adding multiple parallel operations#67

Merged
pcarbo merged 2 commits intostephenslab:masterfrom
eweine:add_parallelism
Apr 17, 2026
Merged

improved speed through adding multiple parallel operations#67
pcarbo merged 2 commits intostephenslab:masterfrom
eweine:add_parallelism

Conversation

@eweine
Copy link
Copy Markdown

@eweine eweine commented Apr 17, 2026

No description provided.

@pcarbo
Copy link
Copy Markdown
Member

pcarbo commented Apr 17, 2026

@eweine This looks great. If I understand correctly, you have sped up two functions, "cost" and "poisson_nmf_kkt". Can I request a couple small changes:

(1) In cost(), add a third setting for "version", and call it "Rcpp_parallel", and then we can easily compare version = "Rcpp" vs. version = "Rcpp_parallel" to check that they produce the same result.

(2) Similarly, in poisson_nmf_kkt() please add a "version" argument with two settings, "Rcpp" and "Rcpp_parallel".

Thanks!

@eweine
Copy link
Copy Markdown
Author

eweine commented Apr 17, 2026

@pcarbo yes, those are the two functions that I have sped up by making parallel.

I added a third version for cost and poisson_nmf_kkt, and added a few tests to confirm that the results are equivalent between version Rcpp and Rcpp_parallel

@pcarbo pcarbo merged commit 2debd8d into stephenslab:master Apr 17, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants