improved speed through adding multiple parallel operations#67
Merged
pcarbo merged 2 commits intostephenslab:masterfrom Apr 17, 2026
Merged
improved speed through adding multiple parallel operations#67pcarbo merged 2 commits intostephenslab:masterfrom
pcarbo merged 2 commits intostephenslab:masterfrom
Conversation
Member
|
@eweine This looks great. If I understand correctly, you have sped up two functions, "cost" and "poisson_nmf_kkt". Can I request a couple small changes: (1) In cost(), add a third setting for "version", and call it "Rcpp_parallel", and then we can easily compare version = "Rcpp" vs. version = "Rcpp_parallel" to check that they produce the same result. (2) Similarly, in poisson_nmf_kkt() please add a "version" argument with two settings, "Rcpp" and "Rcpp_parallel". Thanks! |
Author
|
@pcarbo yes, those are the two functions that I have sped up by making parallel. I added a third version for cost and poisson_nmf_kkt, and added a few tests to confirm that the results are equivalent between version Rcpp and Rcpp_parallel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.