fix: freeze F during prediction in project_poisson_nmf#65
Merged
pcarbo merged 2 commits intostephenslab:masterfrom Apr 17, 2026
Merged
fix: freeze F during prediction in project_poisson_nmf#65pcarbo merged 2 commits intostephenslab:masterfrom
pcarbo merged 2 commits intostephenslab:masterfrom
Conversation
Without `update.factors = NULL`, fit_poisson_nmf used its default seq(1, ncol(X)) and refitted every row of F on the new (test) data, silently corrupting the training-estimated factors. Adding `update.factors = NULL` reduces to integer(0), which causes the main update loop to skip all factor updates so that only L is learned for the new data points.
The test verifies project_poisson_nmf returns F with the same column-normalised structure as the input (catches the update.factors = NULL fix)
roi-meir
force-pushed
the
bugfix/fix_f_matrix_in_predict
branch
from
aaae836 to
dbad59b
Compare
Member
|
@roi-meir Thank you very much for the important fix. I'm not sure how and when this issue came about, but it is certainly a current bug in |
Contributor
Author
|
@pcarbo thank you for the fast response! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without
update.factors = NULL, fit_poisson_nmf used its default seq(1, ncol(X)) and refitted every row of F on the new (test) data, silently corrupting the training-estimated factors. Addingupdate.factors = NULLreduces to integer(0), which causes the main update loop to skip all factor updates so that only L is learned for the new data points.Fix issue #64