Repository navigation
Build without warnings - #100
Merged
Merged
Conversation
- Three test sources: two matches made exhaustive (UdpDestination, ProcedureOutcome.Excluded) and Map's deprecated varargs + replaced with ++. - Surefire talks to its forked JVM over TCP, so the console output tests print through Jansi, straight to the native stdout, no longer corrupts its channel. - The runnable jar leaves out the dependencies' module-info.class files, which the shade plugin warned about: it's one jar on the class path, not a module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A clean
mvn packageprinted warnings from the Scala compiler, Surefire and the shade plugin. It now prints none.UnsolicitedNetworkTest(UdpDestination) andCollisionAvoidanceTest(ProcedureOutcome.Excluded).EventRulesTestuses++instead ofMap's deprecated varargs+. What the tests check doesn't change.Colorsprints through Jansi'sAnsiConsole.out(), which writes to the process's native stdout, and Surefire uses that stdout to talk to its forked JVM. Surefire now uses TCP for that instead (SurefireForkNodeFactory, as its FAQ advises). Only the build changes; the CLI prints as before.module-info.classfiles. It's one jar on the class path, not a module. The jar still runs.Testing:
mvn clean test(591 tests pass) andmvn packageshow no warnings, and the-clijar runs-revs.