Repository navigation
chore: Cherry-pick changes from upstream - #27
Merged
Merged
Conversation
Contributor
Author
|
📦 Target Release Version: 2.37.2 |
anurag-stepsecurity
added
the
review-required
Contributor
PR ReviewAction TypeNode-based action (runs on Passed Checks
Failed ChecksNone — all checklist items passed. Warnings
Security FindingsNo exploitable security vulnerabilities were introduced. This PR is primarily a security improvement that:
SummaryThis cherry-pick PR brings solid security hardening from upstream and all mandatory checklist items pass. The two warnings around the mutable |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const pattern = strict | ||
| ? /[$`"';|&(){}[\]\\<>*?\n\r\t]/g | ||
| : /[$`"';|&(){}[\]\\\n\r\t]/g; | ||
| return value.replace(pattern, ''); |
Contributor
There was a problem hiding this comment.
Warning: loose mode omits shell redirection and glob characters
In non-strict mode (the default), <, >, *, and ? are not removed. These characters can be exploited for shell redirection (>, <) or glob expansion (*, ?) in some invocation contexts.
Strict mode (used for extensions input) already strips these. Consider whether loose-mode callers — particularly tool version strings that flow into shell commands — are safe, or whether the loose pattern should also strip redirection/glob chars:
Suggested change
| return value.replace(pattern, ''); | |
| const pattern = strict | |
| ? /[$`"';|&(){}[\]\\<>*?\n\r\t]/g | |
| : /[$`"';|&(){}[\]\\<>*?\n\r\t]/g; |
| } | ||
| return fs | ||
| .readFileSync( | ||
| path.join(__dirname, '../src/configs/composer-gh-auth-no-op'), |
Contributor
There was a problem hiding this comment.
Warning: silent failure if config file is missing
fs.readFileSync will throw if composer-gh-auth-no-op is not found at the expected path (e.g. after a layout change or during testing outside the action root). The uncaught exception would propagate and crash the action. Consider wrapping with a try/catch that logs a warning and returns false, or assert the file's existence with a clear error message:
if (!fs.existsSync(filePath)) {
core.warning('composer-gh-auth-no-op config not found; skipping composer auth check.');
return false;
}
Contributor
🔍 Cherry-Pick Verification Report📦 Upstream Changes: 📋 File-by-File Analysis:
|
| export async function getManifestURLS(): Promise<string[]> { | ||
| return [ | ||
| 'https://raw.githubusercontent.com/step-security/setup-php/main/src/configs/php-versions.json', | ||
| 'https://raw.githubusercontent.com/shivammathur/setup-php/develop/src/configs/php-versions.json', |
Contributor
There was a problem hiding this comment.
in cherry-pick we have examples folder, we have in main as well, but here we dont have
Contributor
Author
There was a problem hiding this comment.
Because we already have those changes that's why they're not present in this PR.
Signed-off-by: Anurag Rajawat <anurag@stepsecurity.io>
anurag-stepsecurity
force-pushed
the
auto-cherry-pick
branch
from
August 27, 2026 11:58
def5596 to
6062f6e
Compare
Contributor
🔍 Cherry-Pick Verification Report📦 Upstream Changes: 📋 File-by-File Analysis:
|
Raj-StepSecurity
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shivammathur/setup-php@2.37.0...2.37.2