chore: Cherry-pick changes from upstream - #302
Conversation
Signed-off-by: Anurag Rajawat <anurag@stepsecurity.io>
Signed-off-by: Anurag Rajawat <anurag@stepsecurity.io>
6f91dcd to
7532f62
Compare
|
📦 Target Release Version: |
Signed-off-by: Anurag Rajawat <anurag@stepsecurity.io>
7532f62 to
350fdfb
Compare
🔍 Cherry-Pick Verification Report📦 Upstream Changes: 📋 File-by-File Analysis:
|
PR ReviewAction TypeNode-based - uses node24 runtime with dist/restore.js as main and dist/save.js as post entry points (migrated from ncc to Rollup flat-dist layout in this PR). Passed Checks
Failed Checks
Warnings
Security FindingsNo critical security issues found. The cmdFormat metacharacter concern is low severity and scoped to the workflow author. SummaryThis PR cherry-picks upstream v2.9.1 to v2.9.2 changes: removes buildjet support, migrates build toolchain from ncc to Rollup (ESM output), fixes missing await on getCacheProvider(), and expands SAVE_TARGETS to include cdylib/dylib/rlib/staticlib. The single blocking issue is the LICENSE file missing a copyright line for the original upstream author (Swatinem). The dead workflow_run condition in auto_cherry_pick.yml should also be cleaned up. |
| cherry-pick: | ||
| if: github.event_name == 'workflow_dispatch' || contains(fromJson(toJson(github.event.pull_request.labels)).*.name, 'review-required') | ||
| uses: step-security/reusable-workflows/.github/workflows/auto_cherry_pick.yaml@fix_Verify_cherry_pick-Logic | ||
| if: (github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success') || github.event_name == 'workflow_dispatch' || contains(fromJson(toJson(github.event.pull_request.labels)).*.name, 'review-required') |
There was a problem hiding this comment.
Dead condition — workflow_run trigger is missing.
The if: clause includes github.event_name == 'workflow_run' but the workflow's on: block only declares workflow_dispatch and pull_request triggers. A workflow_run event can never reach this workflow, so this branch of the condition is unreachable dead code.
Either add a workflow_run: trigger to on: (if the intent is to fire after another workflow completes), or remove the workflow_run clause:
| if: (github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success') || github.event_name == 'workflow_dispatch' || contains(fromJson(toJson(github.event.pull_request.labels)).*.name, 'review-required') | |
| if: github.event_name == 'workflow_dispatch' || contains(fromJson(toJson(github.event.pull_request.labels)).*.name, 'review-required') |
Swatinem/rust-cache@v2.9.1...v2.9.2