Repository navigation
[SMTNC-3098] Set the get_activated_entry() deprecation version to 2.0.1 - #210
Merged
Merged
Conversation
…2.0.1 [SMTNC-3098]
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Comment |
dpanta94
approved these changes
Oct 12, 2026
2 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
SMTNC-3098
🗒️ Description
v2.0.0 shipped
Product_Collection::get_activated_entry()with its deprecation version still set toTBD, so every consumer that still calls it logs "deprecated since version TBD!". This sets both spots to2.0.1:@deprecatedin the docblock (L64)_deprecated_function()(L71)No changelog entry: this only corrects the version in a notice. The existing
Product_CollectionTestcases assert the deprecation by method name only, so they are unaffected.For context: tribe-common hit this deprecation on Harbor 2.0.0 (31 integration failures on "Unexpected deprecation notice"). It now calls
get_all_by_slug()instead: the-events-calendar/tribe-common#3057.Heads-up, not changed here:
changelog/experiment-software-stack.yamlwas never processed intochangelog.txt, so v2.0.0 has no changelog section. If 2.0.1 goes out through Release Prep, that entry will land under 2.0.1.None.