Repository navigation
fix(swap): return to home when Close is tapped mid-submission - #3024
Open
daniel-carroll-stellar wants to merge 2 commits into
Open
daniel-carroll-stellar wants to merge 2 commits into
daniel-carroll-stellar wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
daniel-carroll-stellar
marked this pull request as ready for review
September 30, 2026 16:31
piyalbasu
added a commit
that referenced
this pull request
Oct 6, 2026
* test(e2e): stub v1 balances in the unfunded-swap test "Swap doesn't throw error when account is unfunded" logs in with the unstubbed login() helper, which blocks on the TESTNET balances response. #2906 replaced the test's v1 stub with a v2-only one, but the client still defaults to v1 (use_balances_v2 is false unless Amplitude enables it), so the v1 request went to the real indexer. On fork PRs and dependabot runs CI has no INDEXER_URL secret and builds with http://indexer.invalid; the request fails, no response event fires, and the test times out on every retry (e.g. #3024, run 36743657621). Stub v1 /account-balances/ as unfunded alongside the v2 route, matching collectiblesEmptyStateCta.test.ts. Verified 2026-10-06 against a local build with INDEXER_URL=INDEXER_V2_URL=http://indexer.invalid: fails before the change at helpers/login.ts:61, passes 3/3 after. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(e2e): correct "v2 is the default balances source" comments The client defaults to v1 balances (use_balances_v2 is false unless remote config enables it). The same false belief led #2906 to drop the v1 stub from the unfunded-swap test; fix the two remaining copies so the pattern isn't repeated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
piyalbasu
approved these changes
Oct 6, 2026
piyalbasu
left a comment
piyalbasu
left a comment
Contributor
There was a problem hiding this comment.
LGTM! The tests were failing for an unrelated reason (that I just fixed), so this is now ready to merge 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2446
What
Tapping Close on the "Swapping…"/"Sending…" screen called
window.close(), which closed the whole extension popup. It now navigates to the home screen as intended.Tests
window.closeis not called.Screenshots
New behavior:
Screen.Recording.2026-09-30.at.12.19.34.PM.mov