Repository navigation
Add Socket Basics security scanning workflow - #3014
Merged
Merged
Conversation
kanwalpreetd
force-pushed
the
master
branch
4 times, most recently
from
September 26, 2026 01:27
8d447c6 to
082d27e
Compare
kanwalpreetd
marked this pull request as ready for review
September 28, 2026 12:37
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved critical and moderate security-scan configuration and workflow issues require changes before approval.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Adds a scheduled and manually triggered Socket Basics security scanning workflow.
Changes:
- Configures SAST and secret scanning.
- Adds Semgrep exclusion rules.
- Adds a pinned Docker-based GitHub Actions workflow.
| File | Summary |
|---|---|
.socket-basics.json |
Configures scanner features and exclusions; several security coverage issues require changes. |
.semgrepignore |
Defines SAST exclusions. |
.github/workflows/socket-basics.yml |
Runs the scheduled/manual scan; completion handling has a critical issue. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kanwalpreetd
force-pushed
the
master
branch
from
September 29, 2026 07:14
082d27e to
c5e9571
Compare
kanwalpreetd
force-pushed
the
master
branch
from
September 29, 2026 07:28
c5e9571 to
b6b612b
Compare
kanwalpreetd
force-pushed
the
master
branch
from
September 29, 2026 08:50
b6b612b to
aa4e3f7
Compare
kanwalpreetd
force-pushed
the
master
branch
from
September 29, 2026 09:29
aa4e3f7 to
9c4ce4b
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved findings affect scan enforcement, result reporting, and security coverage.
Review effort: Lite
Findings: 2
Open (6)
kanwalpreetd
force-pushed
the
master
branch
from
September 29, 2026 22:03
9c4ce4b to
3b80b4c
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Fix scanner failure-status handling and avoid globally disabling sensitive-data logging detection.
Review effort: Lite
Findings: 1
Open (6)
Resolved since last review (1)
kanwalpreetd
force-pushed
the
master
branch
from
September 29, 2026 22:40
3b80b4c to
78e1c3d
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Moderate issues could mask security findings or scanner failures.
Review effort: Lite
Findings: 1
Open (7)
kanwalpreetd
force-pushed
the
master
branch
from
September 29, 2026 23:16
78e1c3d to
794d050
Compare
kanwalpreetd
force-pushed
the
master
branch
from
September 30, 2026 00:16
794d050 to
cfd729e
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Security scan suppressions and exclusions are broader than recommended.
Review effort: Lite
Findings: 6
Open (6)
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Remove the global sensitive-data-in-logs suppression and use path-specific overrides for verified false positives.
Review effort: Lite
Findings: 5
Open (5)
Resolved since last review (1)
Runs SAST through OpenGrep, secret scanning through TruffleHog, and
Dockerfile misconfiguration scanning through Trivy, submitting results
to Socket.dev.
.github/workflows/socket-basics.yml scheduled weekly + manual dispatch
.socket-basics.json scanner configuration
.semgrepignore SAST path exclusions
.trivyignore Dockerfile lint rules with no
security dimension (only present
where the repo has a Dockerfile)
Separate from socket-scan.yml, which covers dependency CVEs and Tier 1
reachability.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Broad scanner suppressions can hide future secrets, credentials, and sensitive-data logging.
Review effort: Lite
Findings: 5
Open (5)
Contributor
Author
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
All reviewed changes are covered and no unresolved blocking issues were identified.
0 open findings
5 resolved since last review
🧠 Review effort: Lite
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
JakeUrban
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More info: https://stellarorg.atlassian.net/wiki/spaces/SCRT/pages/5901680652/Socket+Basics+Integration+Guide