Repository navigation
Conversation
Add a disconnect section to the connecting guide and a playground page. The playground needs index.html to load a freighter-api release that includes disconnect. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M6pbgqeBtJ7cL5biPuxBJ1
✅ Deploy Preview for play-freighter-app ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
An idle lock keeps the active account, so disconnect works then. It only fails before the first unlock after the browser starts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M6pbgqeBtJ7cL5biPuxBJ1
There was a problem hiding this comment.
🟡 Changes recommended
The playground must load a release that includes disconnect() before approval.
1 open finding
What changed in this PR
This PR documents the new disconnect() API and adds an interactive playground with navigation links.
Changes:
- Documents behavior, errors, and account/network scope.
- Adds a disconnect playground.
- Adds navigation links.
- Requires updating the playground’s API version before merging.
| File | Summary |
|---|---|
playgrounds-home.md |
Adds the disconnect playground link. |
extension/playground/disconnect.md |
Adds the playground; its API version currently predates disconnect(). |
extension/connecting.md |
Documents disconnect(); authorization wording should be scoped to the active account and network. |
_sidebar.md |
Adds sidebar navigation. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| el.className = 'playground-result'; | ||
| el.textContent = 'Disconnecting...'; | ||
| try { | ||
| var res = await window.freighterApi.disconnect(); |
There was a problem hiding this comment.
Correct. This is a known merge blocker. The "Before merge" section of the PR description tells it.
The version change cannot occur now. No freighter-api release on npm includes disconnect() yet. stellar/freighter#3036 adds the method. After that release is on npm, this PR will change index.html to load it.
Until then, 186562a prevents the TypeError. If the loaded freighter-api does not include disconnect(), the page now shows this error: "the loaded version of @stellar/freighter-api does not include disconnect()". This thread stays open until the version change.
Generated by Claude Code
index.html loads a freighter-api version without disconnect() until the next release. Show that cause instead of a TypeError. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M6pbgqeBtJ7cL5biPuxBJ1
|
We need to release the disconnect method before we merge this docs update so the playground has the updated sdk. |
What
This PR adds documentation for the new
disconnect()method in@stellar/freighter-api. The method is added in stellar/freighter#3036.Changes:
extension/connecting.md: Adds a "Disconnecting" section. The section tells:disconnect()does and what it returns.requestAccess()orsetAllowed()call shows a prompt again.disconnect().disconnect()removes access only for the active account on the active network. The dApp keeps access to other accounts and networks that the user authorized before. The dApp gets that access again, without a prompt, when the user changes to one of them.extension/playground/disconnect.md: Adds a playground page with a "Disconnect" button._sidebar.mdandplaygrounds-home.md: Add links to the new playground page.Before merge
index.htmlloads@stellar/freighter-api@6.0.1. That version does not havedisconnect(), so the playground button does not operate. Changeindex.htmlto load the freighter-api release that includesdisconnect(). Do this after that release is on npm.🤖 Generated with Claude Code
https://claude.ai/code/session_01M6pbgqeBtJ7cL5biPuxBJ1
Generated by Claude Code