Repository navigation
fix(security): remove dead signComment, document CSP style-src decision - #751
Open
rejoicetukura-blip wants to merge 1 commit into
Conversation
|
@rejoicetukura-blip Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #641
Closes #644
signMessage.ts's raw-KeypairSEP-53 signing path is reachable, dead, or a private-key-handling risk #644: audit foundsignComment(rawKeypairsigning) had zero call sites outside its own module; removed and documented indocs/wallet-adapters.md. Production message signing isbuildAuthTransaction+ wallet adapter.'unsafe-inline'from the CSPstyle-srcdirective #641: nonce-basedstyle-srcis not feasible today (Next.js inline styles are not nonced); added dated note incsp.tsanddocs/security-audit.mdnaming the blocking condition and trigger.closes #642
closes #643
ocked because
xdrReview.ts,wallet/types.ts,wallet/index.tsandfreighterAdapter.tsare 0-byte files onmain.Validation:
tsc --noEmitshows no errors in touched files.next lintfails on a pre-existing ESLint config problem.