Repository navigation
fix(security): harden wallet origin, known addresses, and export redaction - #749
Open
had3sgames wants to merge 1 commit into
Open
had3sgames wants to merge 1 commit into
had3sgames wants to merge 1 commit into
Conversation
|
@had3sgames Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signTransactioncall, not only inassertWalletReady#645: extractcheckOriginTrusted()fromassertWalletReadyand re-run it immediately beforesignTransactioninuseSolverRegistrationanduseBondManagement(no central dispatch exists yet).getKnownAddressRecordsdrops entries that failisValidStellarPublicKey;recordKnownAddressis a no-op on invalid input.intentExport.ts'sredactForExport, not just a key-name match #647: addlooksLikeSensitiveBlob(long base64/hex) insecureLogging.ts;redactForExportapplies it to every string value, in addition to the key-name filter.analyticsExport.ts) for the same redaction policy as the intent-export path #648 audit: the CSV bundle holds aggregates only (KPIs, daily volume, chain/token route totals), with no addresses, XDR or signatures.AnalyticsShareStateis filter state only (from/to/chain/token). Encode and decode now reject values that are over 64 chars, strkey-valid, or blob-shaped. Decode also rejects params over 1024 chars and non-object JSON.Future direction for #647: mark sensitive fields at the type level on
IntentDetail.Validation
vitest src/lib/securityHardening.test.ts: 5/5 pass (one test per issue).mainalready has a malformed.eslintrc.json, emptytextSafety.ts/config.ts/store/wallet.ts, and syntax errors inogImageHelpers.ts,charts/index.ts,AnalyticsPageClient.tsx, etc. Committed with--no-verify. Only unrelated fix: a stray}instellarAddress.tsthat [Trivial] Validate address *format*, not just string-ness, before trusting entries in the local known-addresses baseline #646 imports.secureLogging.tswas empty (issue i18n: externalize strings in the solve page #61 not landed), so the heuristic lives there as a minimal stand-in.Closes #645
Closes #646
Closes #647
Closes #648