Repository navigation
fix(ci): repair ci.yml jobs and add share-URL privacy guard test - #747
Merged
techisigu merged 1 commit intoOct 23, 2026
Conversation
|
@Coredevjay Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #649
Closes #650
Closes #651
Closes #652
Summary
e2ejob key inci.ymlsilently discards multi-browser coverage #650: removed duplicate/brokene2eblocks; matrixe2ekept, chromium cached job renamede2e-smoke; dropped undefinedmatrix.shardflag.ci-successgate depends on a job name (static) that doesn't exist #651:ci-successnow needsfrontendinstead of non-existentstatic.storybook-visualjob contains a truncated step and duplicated step block #652: removed truncatedupload-artifactref and duplicated Storybook steps.buildShareUrl/encodeShareStateoutput never grows to include wallet-specific data #649: addedanalyticsExport.test.tsasserting share URLs never contain Stellar keys or XDR-like data.Validation
ci.ymlparses as valid YAML with unique job ids.vitest run src/lib/export/analyticsExport.test.tspasses; prettier clean.--no-verify: pre-existing failures on main (malformed.eslintrc.json, tsc syntax errors and merge debris in unrelated files).