Conversation
The AWS RDS IAM section told readers to set an environment variable named literally `spring.datasource.hikari.data-source-properties.wrapperPlugins`. That is not a valid POSIX environment variable name, and some deployment tooling refuses to pass it through. Platform 2.8.8 accepts `STEADYBIT_DB_AWS_JDBC_WRAPPER_<UPPER_SNAKE>` for any wrapper parameter, so the table and the example use that spelling now. Added a note that the old spelling still works and still wins where both are set, and that parameters the wrapper merely forwards to the PostgreSQL driver, such as `logServerErrorDetail`, keep the dotted spelling. (ticket 13919)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://steadybitgmbh.kanbanize.com/ctrl_board/2/cards/13919
Platform PR: https://github.com/steadybit/platform/pull/2046 (merged)
Why
The "AWS RDS IAM Authentication" section told on-prem readers to set an environment variable named literally
spring.datasource.hikari.data-source-properties.wrapperPlugins, and documentedwrapperDialectthe same way. Dots and mixed case are not valid in a POSIX environment variable name, and some deployment tooling refuses to pass such a variable through — which is what the ticket was raised for.The platform now accepts
STEADYBIT_DB_AWS_JDBC_WRAPPER_<UPPER_SNAKE>for any wrapper parameter and translates it back to the camel-cased property the wrapper reads.What changed
Only
install-and-configure/install-on-prem-platform/advanced-configuration.md:STEADYBIT_DB_AWS_JDBC_WRAPPER_WRAPPER_PLUGINSandSTEADYBIT_DB_AWS_JDBC_WRAPPER_WRAPPER_DIALECT.wrapperLoggerLevelbecomesSTEADYBIT_DB_AWS_JDBC_WRAPPER_WRAPPER_LOGGER_LEVEL.logServerErrorDetail, are not covered by the prefix and keep the dotted spelling.The table is re-padded to the new column width, per the repo's table convention.
Please check the version number
The note says "Before platform 2.8.8". That is inferred, not confirmed: releases bump with
DEFAULT_BUMP: patchon push tomainand the latest release is 2.8.7, so thefix:commits give 2.8.8 — but if afeat:merges before the release is cut it becomes 2.9.0. Worth correcting before this merges.Checks
python3 .github/scripts/docs_lint.py --base origin/main— 0 errors, 0 warnings (106 pre-existing findings ignored, none introduced).