Repository navigation
build: upgrade Boost & compile C++ test fixture runners w C++14 - #16545
Merged
Merged
Conversation
Upgrades Boost from 1.69.0 to 1.92.0, the current release, and replaces
its download checksum with the one Boost publishes. Moves the C++ test
fixture runner Makefiles and their snippet template from `-std=c++11` to
`-std=c++14`, the minimum standard Boost.Math requires. Under C++11,
current Boost.Math warns "Boost.Math requires C++14", and the runners
don't build against it.
Assisted-by: Claude Opus 5.5
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Member
Yes. Would you mind submitting a follow-up PR? |
Member
|
Re: watch-outs. Yes, please feel free to submit follow-up PRs. Cheers! |
Member
|
As the CI failure is expected, I'll go ahead and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Description
This pull request:
DEPS_BOOST_VERSIONintools/make/common.mk, adds the download checksum Boost publishes forboost_1_92_0.tar.gz, and removes the 1.69.0 checksum.test/fixtures/cpp/Makefile, 22 packages) and the C++ fixture runner snippet template (tools/snippets/test/fixtures/cpp/boost/Makefile) from-std=c++11to-std=c++14.This is part of the "accuracy-visibility" project to create fixtures for several implementations to compare against stdlib and MPFR
C++14 is the min standard Boost.Math requires (
"cxxstd": "14"in itsmeta/libraries.json). Under C++11, current Boost.Math warns "Boost.Math requires C++14", and the runners don't build against it, so fixtures can't be generated or tested against current Boost implementations. 1.92.0 also includes Boost.JSON, first released in 1.75.0, so new fixture runners can read shared JSON inputs.Related Issues
No.
Reference Packages
This pull request followed these packages:
4362cf8, which changed the same three files.common.mk, a new checksum file, and the old one removed.boost_1_92_0.tar.gz.jsonat archives.boost.io.meta/libraries.json: Boost.Math needs C++14, and Boost.Random, the only other Boost library the runners include, needs C++11.Questions
benchmark/cpp/boostMakefiles, andCOMMON_CXXFLAGSintools/make/common.mk, move to C++14 as well? They build against the new Boost either way.Other
make install-deps-boostat 1.92.0 downloads, verifies, extracts, and passes its install test, and 21 of the 22 runners build at-std=c++14with no warnings. On macOS on Apple silicon (Apple clang 21),make install-deps-boostandmake test-fixtures-cpp-fileswork with no overrides, using the new defaults.ellipe's runner doesn't build at either standard or Boost version, because it callsellint_1with nousingdeclaration (runner.cppline 289). That's left for a separate PR, to keep this one minimal.expm1's runner throws an overflow error at its last input (x = 709.78) before writingmedium_positive.json. No fixtures are regenerated here, so it only affects a later regeneration.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Claude (Opus 5.5) found the files the upgrade touches, made the changes, and checked the Boost 1.92.0 install and the runner builds on x86_64 Linux and macOS. I reviewed the changes and the findings, PR description, etc.
@stdlib-js/reviewers