Repository navigation
fix: accept uppercase schemes - #16544
Merged
kgryte merged 1 commit intoNov 8, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
assert/is-absolute-http-uri
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
makes the scheme check in
assert/is-absolute-http-uricase-insensitive. URI schemes are case-insensitive (RFC 3986, Section 3.1), andassert/is-urialready accepts an uppercase scheme, but the function only matched lowercasehttp://andhttps://:For comparison,
new URL( 'HTTPS://example.com' ).protocolis'https:'.adds a test for uppercase and mixed-case schemes.
Related Issues
None.
Questions
No.
Other
assert/is-uri. Non-HTTP(S) schemes (e.g.,ftp://,ws://) are still rejected.develop(4 assertions); all existing tests pass unchanged.tapeon Windows (asmakewas not available in my environment); I did not run the full repository lint pipeline locally.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written with the help of Claude Code, which found the issue, drafted the change and test, and ran the verification described above. I reviewed the changes and the test results before submitting.
@stdlib-js/reviewers
🤖 Generated with Claude Code