Skip to content

refactor: use constants/float64/nan in stats/base/dists/laplace/mode - #16537

Merged
kgryte merged 1 commit into
stdlib-js:developfrom
devxsubh:refactor/laplace-mode-nan
Nov 8, 2026
Merged

kgryte merged 1 commit into
stdlib-js:developfrom
devxsubh:refactor/laplace-mode-nan

Conversation

@devxsubh

@devxsubh devxsubh commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • replaces inline NaN generation in the C implementation of stats/base/dists/laplace/mode with STDLIB_CONSTANT_FLOAT64_NAN
  • adds @stdlib/constants/float64/nan to the build, benchmark, and examples manifest entries

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Reference Packages

Did the content of this pull request follow one or more existing packages? Answering is optional.

This pull request followed these packages:

What carried over from the reference(s)?

  • include placement, macro usage, and manifest dependency updates

What differed, or what did you have to work out yourself?

  • checked the benchmark, example, and README C snippets; none had inline NaN, so only src/main.c changed
  • compiled src/main.c before and after the change (-O2 -Wall -Wextra): no warnings, and the generated machine code is identical, since the macro expands to ( 0.0 / 0.0 )

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code, which applied the refactor and verified it by compiling the old and new C source and comparing the generated machine code. I reviewed the diff before submitting.


@stdlib-js/reviewers

@devxsubh
devxsubh requested a review from a team November 7, 2026 16:31
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Nov 7, 2026
@devxsubh
devxsubh force-pushed the refactor/laplace-mode-nan branch from bd773e5 to 68d5cbb Compare November 8, 2026 02:00
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 and removed Needs Review A pull request which needs code review. labels Nov 8, 2026

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/laplace/mode $\\color{green}175/175$
$\\color{green}+100.00\\%$
$\\color{green}9/9$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}175/175$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Nov 8, 2026
@kgryte
kgryte merged commit dd9b3f6 into stdlib-js:develop Nov 8, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. review: 5 Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants